roderick-koehle
a115788ea5
Remove spaces in empty line
2021-07-14 11:53:31 +02:00
roderick-koehle
c2bbe78e86
Remove comment
2021-07-14 11:16:00 +02:00
roderick-koehle
16cfc7fd38
Remove commented out line
2021-07-14 11:15:10 +02:00
roderick-koehle
305521e014
Merge branch 'borglab:develop' into python-fisheye-interface
2021-07-14 09:37:32 +02:00
roderick-koehle
d130387a7d
Minor fix test_Cal3Fisheye
2021-07-13 22:12:14 +02:00
roderick-koehle
3e41ece75a
Minor fix test_Cal3Unified
2021-07-13 22:10:38 +02:00
roderick-koehle
17c37de7c4
Shared setup triangulation unit test
2021-07-13 22:07:19 +02:00
roderick-koehle
3402e46ad1
Shared data for triangulation unit tests
2021-07-13 22:00:21 +02:00
John Lambert
fa42d96360
Merge pull request #817 from borglab/wrapper-shonan-averaging-2
...
Add ShonanAveraging2 interface to wrapper with BetweenFactorPose2s, that does not require g2o files
2021-07-13 13:37:34 -06:00
John Lambert
54d3471121
update logic in angular error comparison
2021-07-13 08:18:45 -06:00
roderick-koehle
f53f5db4d1
Merge branch 'borglab:develop' into python-fisheye-interface
2021-07-13 12:03:10 +02:00
John Lambert
c4a4e13196
fix assert on angles
2021-07-13 00:16:24 -06:00
John Lambert
d7151ed284
use mod when comparing angles
2021-07-12 20:52:36 -04:00
John Lambert
cce952fbb3
use simple example for unit test
2021-07-12 19:35:34 -04:00
John Lambert
690300124c
fix typo
2021-07-11 22:47:14 -04:00
John Lambert
61c5e89de3
try increasing pmax to pass test
2021-07-11 22:46:54 -04:00
Varun Agrawal
39b1b15c3e
Merge pull request #819 from borglab/feature/std-bind-placeholders
2021-07-11 07:33:32 -07:00
roderick-koehle
c595767cae
Unittest, triangulation for Cal3Unified
2021-07-11 14:14:08 +02:00
roderick-koehle
941594c94b
Testing CameraSet and triangulatePoint3
...
Currently triangulatePoint3 returns wrong results for fisheye models. The template for PinholePose may be implemented for a fixed size of variable dimensions.
2021-07-11 14:11:40 +02:00
John Lambert
ddfb45efb0
fix typo in block indexing, 3x3 covariance for Pose2 should have just 1x1 block for theta
2021-07-11 01:02:36 -06:00
Varun Agrawal
dfc77f0967
Merge pull request #818 from borglab/tbb-disabling-instructions
2021-07-10 21:07:15 -04:00
Varun Agrawal
d5890a2d61
update all the tests
2021-07-10 21:03:15 -04:00
Varun Agrawal
dc8b5e58ff
replaced boost with std for placeholders, bind and function
2021-07-10 21:01:20 -04:00
roderick-koehle
0a73961f5a
Update ignore list in CMakeFile
2021-07-10 23:05:53 +02:00
roderick-koehle
3118fde6d3
Missing CameraSet binding specialisations
...
Add pybind specialisations for CameraSetCal3Unified and CameraSetCal3Fisheye.
2021-07-10 23:00:24 +02:00
roderick-koehle
d54e234f93
Add ambiguous calibrate/uncalibrate declarations.
...
Without declaring calibrate / uncalibrated in the interface specification, the functions of the Base class Cal3DS2_Base is called.
The layout of the optional Jacobian matrix is 2x10 in Cal3Unified and 2x9 in Cal3DS2_Base, so this are different function calls.
2021-07-10 22:03:17 +02:00
John Lambert
aebb90573a
set pmin and pmax in unit test
2021-07-10 11:41:46 -04:00
John Lambert
63236cf7af
improve wrapper compilation instructions, when TBB not installed
2021-07-10 11:37:59 -04:00
John Lambert
8b86d7a51c
improve docs about compiling without TBB
2021-07-10 11:36:36 -04:00
John Lambert
db801f164d
add missing import to python unit test
2021-07-10 10:31:27 -04:00
roderick-koehle
03049929a5
Add comment about initial guess in undistortion
...
For the equidistant fisheye model, r/f = tan(theta), the Gauss-Newton search to model radial distortion is expected to converge faster by mapping the angular coordinate space into the respective tangent space of the perspective plane. This is consistent to the nPlaneToSpace initial projection used in the calibrate() function of the omnidirectional model (Cal3Unified).
2021-07-10 15:21:22 +02:00
John Lambert
64514387b4
check in python unit test for new functionality
2021-07-10 00:57:01 -04:00
John Lambert
7fc8f23367
use default parameters if none provided, and remove gtsam namespace prefix in .h file
2021-07-09 23:34:55 -04:00
Varun Agrawal
4ac4302871
Merge pull request #813 from borglab/feature/between-factor-tests
2021-07-09 18:19:29 -04:00
Varun Agrawal
4fc68593ac
Merge pull request #814 from borglab/fix/misc
2021-07-09 18:19:03 -04:00
John Lambert
641a01c726
fix typo on 3x3 matrix def
2021-07-09 17:54:14 -04:00
John Lambert
4bf2308ec5
add conversion function for Pose2 -> BinaryMeasurement<Rot2>
2021-07-09 17:48:26 -04:00
John Lambert
3c8cdb4eee
add ShonanAveraging2 constructor to wrapper, that accepts BetweenFactorPose2s as input
2021-07-09 17:42:59 -04:00
John Lambert
0e0d630c91
fix typo
2021-07-09 17:39:38 -04:00
John Lambert
3c1823349b
add interface in C++, and helper extractRot2Measurements()
2021-07-09 17:38:10 -04:00
John Lambert
15478bf278
Update ShonanAveraging.h
2021-07-09 17:33:33 -04:00
Varun Agrawal
2e40169324
fix dimension for Pose3 test
2021-07-09 14:07:19 -04:00
Varun Agrawal
8b9e60156c
cleaner variables
2021-07-09 14:06:59 -04:00
roderick-koehle
66af0079ba
Improved accuracy for analytic undistortion
2021-07-09 12:39:31 +02:00
roderick-koehle
a411b664a1
Correct tab to spaces to fix formatting
2021-07-09 11:25:18 +02:00
roderick-koehle
6205057ccb
Use of common setUpClass method
2021-07-09 11:17:38 +02:00
roderick-koehle
bdeb60679b
Introduce setUpClass, python snake_case variables
...
Test case fails if object depth z is not equal 1.
2021-07-09 11:14:10 +02:00
Varun Agrawal
d7d9ac0f06
typo fix
2021-07-08 19:43:25 -04:00
Varun Agrawal
a12b49de40
add Pose3 expmap to wrapper
2021-07-08 19:43:09 -04:00
Varun Agrawal
2ecad47b9e
Added lots of tests for BetweenFactor
2021-07-08 19:41:01 -04:00