12345qiupeng
/
gtsam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use Assignment<Key> for evaluate since it is the base class

release/4.3a0
Varun Agrawal 2024-12-07 18:59:11 -05:00
parent 9f88a360df
commit 2a3b5e62b7
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtsam/discrete/DiscreteFactor.h
View File

@ -94,7 +94,7 @@ class GTSAM_EXPORT DiscreteFactor : public Factor {
size_t cardinality(Key j) const { return cardinalities_.at(j); }
/// Find value for given assignment of values to variables
virtual double operator()(const DiscreteValues&) const = 0;
virtual double operator()(const DiscreteValues& values) const = 0;
/// Error is just -log(value)
virtual double error(const DiscreteValues& values) const;

3
gtsam/discrete/TableFactor.h
View File

@ -177,9 +177,6 @@ class GTSAM_EXPORT TableFactor : public DiscreteFactor {
/// Evaluate probability distribution, sugar.
double operator()(const Assignment<Key>& values) const;
double operator()(const DiscreteValues& values) const override {
return operator()(Assignment<Key>(values));
}
/// Calculate error for DiscreteValues `x`, is -log(probability).
double error(const DiscreteValues& values) const override;