From 2a3b5e62b785c2c9de4e414f5dcb1551569a297c Mon Sep 17 00:00:00 2001
From: Varun Agrawal <varagrawal@gmail.com>
Date: Sat, 7 Dec 2024 18:59:11 -0500
Subject: [PATCH] use Assignment<Key> for evaluate since it is the base class

---
 gtsam/discrete/DiscreteFactor.h | 2 +-
 gtsam/discrete/TableFactor.h    | 3 ---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/gtsam/discrete/DiscreteFactor.h b/gtsam/discrete/DiscreteFactor.h
index 23abf725e..4470d97a7 100644
--- a/gtsam/discrete/DiscreteFactor.h
+++ b/gtsam/discrete/DiscreteFactor.h
@@ -94,7 +94,7 @@ class GTSAM_EXPORT DiscreteFactor : public Factor {
   size_t cardinality(Key j) const { return cardinalities_.at(j); }
 
   /// Find value for given assignment of values to variables
-  virtual double operator()(const DiscreteValues&) const = 0;
+  virtual double operator()(const DiscreteValues& values) const = 0;
 
   /// Error is just -log(value)
   virtual double error(const DiscreteValues& values) const;
diff --git a/gtsam/discrete/TableFactor.h b/gtsam/discrete/TableFactor.h
index ea222ca5c..8fb04fcba 100644
--- a/gtsam/discrete/TableFactor.h
+++ b/gtsam/discrete/TableFactor.h
@@ -177,9 +177,6 @@ class GTSAM_EXPORT TableFactor : public DiscreteFactor {
 
   /// Evaluate probability distribution, sugar.
   double operator()(const Assignment<Key>& values) const;
-  double operator()(const DiscreteValues& values) const override {
-    return operator()(Assignment<Key>(values));
-  }
 
   /// Calculate error for DiscreteValues `x`, is -log(probability).
   double error(const DiscreteValues& values) const override;