From 74fba4bc633fbb2641607fcc70f18e98527ab6ec Mon Sep 17 00:00:00 2001 From: Varun Agrawal Date: Thu, 3 Apr 2025 19:22:49 -0400 Subject: [PATCH 1/2] fix DiscreteBayesTree::marginalFactor return type --- gtsam/discrete/discrete.i | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtsam/discrete/discrete.i b/gtsam/discrete/discrete.i index 74de7a922..d483782f3 100644 --- a/gtsam/discrete/discrete.i +++ b/gtsam/discrete/discrete.i @@ -288,7 +288,7 @@ class DiscreteBayesTree { const DiscreteBayesTreeClique* clique(size_t j) const; size_t numCachedSeparatorMarginals() const; - gtsam::DiscreteConditional marginalFactor(size_t key) const; + gtsam::DiscreteConditional* marginalFactor(size_t key) const; gtsam::DiscreteFactorGraph* joint(size_t j1, size_t j2) const; gtsam::DiscreteBayesNet* jointBayesNet(size_t j1, size_t j2) const; From 5ab2e3f03b67e5120490bc2a1e53d8f468c28bb5 Mon Sep 17 00:00:00 2001 From: Varun Agrawal Date: Thu, 3 Apr 2025 19:26:20 -0400 Subject: [PATCH 2/2] fix return type of DiscreteFactorGraoh::product --- gtsam/discrete/discrete.i | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtsam/discrete/discrete.i b/gtsam/discrete/discrete.i index d483782f3..91176601c 100644 --- a/gtsam/discrete/discrete.i +++ b/gtsam/discrete/discrete.i @@ -369,7 +369,7 @@ class DiscreteFactorGraph { void print(string s = "") const; bool equals(const gtsam::DiscreteFactorGraph& fg, double tol = 1e-9) const; - gtsam::DecisionTreeFactor product() const; + gtsam::DiscreteFactor* product() const; double operator()(const gtsam::DiscreteValues& values) const; gtsam::DiscreteValues optimize() const;