From abb92632b868a1a22d80e874bbbf8cd4b17b9177 Mon Sep 17 00:00:00 2001 From: dellaert Date: Wed, 8 Oct 2014 17:32:46 +0200 Subject: [PATCH] Empty derived destructors are not needed --- gtsam_unstable/nonlinear/Expression-inl.h | 29 +++-------------------- 1 file changed, 3 insertions(+), 26 deletions(-) diff --git a/gtsam_unstable/nonlinear/Expression-inl.h b/gtsam_unstable/nonlinear/Expression-inl.h index 85f89a889..31e70e11b 100644 --- a/gtsam_unstable/nonlinear/Expression-inl.h +++ b/gtsam_unstable/nonlinear/Expression-inl.h @@ -263,10 +263,6 @@ class ConstantExpression: public ExpressionNode { public: - /// Destructor - virtual ~ConstantExpression() { - } - /// Return keys that play in this expression, i.e., the empty set virtual std::set keys() const { std::set keys; @@ -306,10 +302,6 @@ class LeafExpression: public ExpressionNode { public: - /// Destructor - virtual ~LeafExpression() { - } - /// Return keys that play in this expression virtual std::set keys() const { std::set keys; @@ -359,10 +351,6 @@ private: public: - /// Destructor - virtual ~UnaryExpression() { - } - /// Return keys that play in this expression virtual std::set keys() const { return expressionA_->keys(); @@ -387,8 +375,7 @@ public: struct Trace: public JacobianTrace { TracePtr trace; JacobianTA dTdA; - virtual ~Trace() { - } + /// Start the reverse AD process virtual void reverseAD(JacobianMap& jacobians) const { trace.reverseAD(dTdA, jacobians); @@ -438,10 +425,6 @@ private: public: - /// Destructor - virtual ~BinaryExpression() { - } - /// Return keys that play in this expression virtual std::set keys() const { std::set keys1 = expressionA1_->keys(); @@ -475,8 +458,7 @@ public: TracePtr trace1, trace2; JacobianTA1 dTdA1; JacobianTA2 dTdA2; - virtual ~Trace() { - } + /// Start the reverse AD process virtual void reverseAD(JacobianMap& jacobians) const { trace1.reverseAD(dTdA1, jacobians); @@ -535,10 +517,6 @@ private: public: - /// Destructor - virtual ~TernaryExpression() { - } - /// Return keys that play in this expression virtual std::set keys() const { std::set keys1 = expressionA1_->keys(); @@ -580,8 +558,7 @@ public: JacobianTA1 dTdA1; JacobianTA2 dTdA2; JacobianTA3 dTdA3; - virtual ~Trace() { - } + /// Start the reverse AD process virtual void reverseAD(JacobianMap& jacobians) const { trace1.reverseAD(dTdA1, jacobians);