diff --git a/.cproject b/.cproject
index c19b1a91a..ec6a2bf6f 100644
--- a/.cproject
+++ b/.cproject
@@ -663,6 +663,14 @@
true
true
+
+ make
+ -j5
+ testGeneralSFMFactor_Cal3Bundler.run
+ true
+ true
+ true
+
make
-j5
diff --git a/examples/PlanarSLAMExample_easy.cpp b/examples/PlanarSLAMExample_easy.cpp
index cd4a7aefd..fc371033e 100644
--- a/examples/PlanarSLAMExample_easy.cpp
+++ b/examples/PlanarSLAMExample_easy.cpp
@@ -18,6 +18,9 @@
// pull in the planar SLAM domain with all typedefs and helper functions defined
#include
+// we will use Symbol keys
+#include
+
using namespace std;
using namespace gtsam;
diff --git a/examples/easyPoint2KalmanFilter.cpp b/examples/easyPoint2KalmanFilter.cpp
index b13058a07..2b4d2476a 100644
--- a/examples/easyPoint2KalmanFilter.cpp
+++ b/examples/easyPoint2KalmanFilter.cpp
@@ -22,6 +22,7 @@
*/
#include
+#include
#include
#include
#include
diff --git a/examples/vSLAMexample/vISAMexample.cpp b/examples/vSLAMexample/vISAMexample.cpp
index 6b47c9633..d23ea9b10 100644
--- a/examples/vSLAMexample/vISAMexample.cpp
+++ b/examples/vSLAMexample/vISAMexample.cpp
@@ -18,15 +18,16 @@
#include "vSLAMutils.h"
#include "Feature2D.h"
-#include
-#include
#include
#include
#include
+#include
+#include
+#include
#include
#include
-using namespace boost;
+using boost::shared_ptr;
using namespace std;
using namespace gtsam;
diff --git a/examples/vSLAMexample/vSFMexample.cpp b/examples/vSLAMexample/vSFMexample.cpp
index 6eb3955f2..be41ad831 100644
--- a/examples/vSLAMexample/vSFMexample.cpp
+++ b/examples/vSLAMexample/vSFMexample.cpp
@@ -18,13 +18,14 @@
#include "vSLAMutils.h"
#include "Feature2D.h"
-#include
-#include
#include
#include
+#include
+#include
+#include
#include
-using namespace boost;
+using boost::shared_ptr;
using namespace std;
using namespace gtsam;
diff --git a/gtsam/nonlinear/ISAM2-impl.cpp b/gtsam/nonlinear/ISAM2-impl.cpp
index 8fe117e34..46fbe94f9 100644
--- a/gtsam/nonlinear/ISAM2-impl.cpp
+++ b/gtsam/nonlinear/ISAM2-impl.cpp
@@ -12,13 +12,15 @@
/**
* @file ISAM2-impl.cpp
* @brief Incremental update functionality (ISAM2) for BayesTree, with fluid relinearization.
- * @author Michael Kaess, Richard Roberts
+ * @author Michael Kaess
+ * @author Richard Roberts
*/
+#include
+#include // for selective linearization thresholds
+#include
#include
#include
-#include
-#include
namespace gtsam {
diff --git a/gtsam/nonlinear/NonlinearFactor.h b/gtsam/nonlinear/NonlinearFactor.h
index bf6527599..12001551c 100644
--- a/gtsam/nonlinear/NonlinearFactor.h
+++ b/gtsam/nonlinear/NonlinearFactor.h
@@ -33,7 +33,6 @@
#include
#include
-#include
/**
* Macro to add a standard clone function to a derived factor
diff --git a/gtsam/nonlinear/Ordering.h b/gtsam/nonlinear/Ordering.h
index 879b50677..f775f168b 100644
--- a/gtsam/nonlinear/Ordering.h
+++ b/gtsam/nonlinear/Ordering.h
@@ -17,14 +17,14 @@
#pragma once
-#include
-#include
+#include
#include
-#include
+#include
#include
#include
#include
+#include
namespace gtsam {
diff --git a/gtsam/nonlinear/tests/testOrdering.cpp b/gtsam/nonlinear/tests/testOrdering.cpp
index f57e3281a..beb16f741 100644
--- a/gtsam/nonlinear/tests/testOrdering.cpp
+++ b/gtsam/nonlinear/tests/testOrdering.cpp
@@ -14,9 +14,10 @@
* @author Alex Cunningham
*/
-#include
-#include
#include
+#include
+#include
+#include
using namespace std;
using namespace gtsam;
diff --git a/gtsam/nonlinear/tests/testSerializationNonlinear.cpp b/gtsam/nonlinear/tests/testSerializationNonlinear.cpp
index 120a9fa94..bc023f115 100644
--- a/gtsam/nonlinear/tests/testSerializationNonlinear.cpp
+++ b/gtsam/nonlinear/tests/testSerializationNonlinear.cpp
@@ -16,11 +16,12 @@
* @date Feb 7, 2012
*/
+#include
+#include
#include
#include
#include
#include
-#include
#include
#include
diff --git a/gtsam/nonlinear/tests/testValues.cpp b/gtsam/nonlinear/tests/testValues.cpp
index 6ccd3b083..f5caa846b 100644
--- a/gtsam/nonlinear/tests/testValues.cpp
+++ b/gtsam/nonlinear/tests/testValues.cpp
@@ -10,28 +10,29 @@
* -------------------------------------------------------------------------- */
/**
- * @file testDynamicValues.cpp
+ * @file testValues.cpp
* @author Richard Roberts
*/
-#include
-#include
-#include
-#include // for operator +=
-using namespace boost::assign;
-
+#include
+#include
+#include
+#include
#include
#include
#include
-#include
-#include
-#include
+
+#include
+#include // for operator +=
+using namespace boost::assign;
+#include
+#include
using namespace gtsam;
using namespace std;
static double inf = std::numeric_limits::infinity();
-const Key key1(Symbol('v',1)), key2(Symbol('v',2)), key3(Symbol('v',3)), key4(Symbol('v',4));
+const Symbol key1('v',1), key2('v',2), key3('v',3), key4('v',4);
/* ************************************************************************* */
TEST( Values, equals1 )
diff --git a/gtsam/slam/GeneralSFMFactor.h b/gtsam/slam/GeneralSFMFactor.h
index d046d0e1b..d64585b7d 100644
--- a/gtsam/slam/GeneralSFMFactor.h
+++ b/gtsam/slam/GeneralSFMFactor.h
@@ -20,9 +20,10 @@
#pragma once
-#include
#include
-
+#include
+#include
+#include
namespace gtsam {
diff --git a/gtsam/slam/pose2SLAM.h b/gtsam/slam/pose2SLAM.h
index 337ab9f7a..84fbc528f 100644
--- a/gtsam/slam/pose2SLAM.h
+++ b/gtsam/slam/pose2SLAM.h
@@ -19,7 +19,6 @@
#include
#include
-#include
#include
#include
#include
diff --git a/gtsam/slam/pose3SLAM.h b/gtsam/slam/pose3SLAM.h
index e42238892..f81070818 100644
--- a/gtsam/slam/pose3SLAM.h
+++ b/gtsam/slam/pose3SLAM.h
@@ -20,7 +20,6 @@
#include
#include
#include
-#include
#include
#include
#include
diff --git a/gtsam/slam/smallExample.cpp b/gtsam/slam/smallExample.cpp
index 2e9194466..b0e709a80 100644
--- a/gtsam/slam/smallExample.cpp
+++ b/gtsam/slam/smallExample.cpp
@@ -18,6 +18,7 @@
*/
#include
+#include
#include
#include
#include
diff --git a/gtsam/slam/tests/testGeneralSFMFactor.cpp b/gtsam/slam/tests/testGeneralSFMFactor.cpp
index 5b8a217bc..f9911ce7d 100644
--- a/gtsam/slam/tests/testGeneralSFMFactor.cpp
+++ b/gtsam/slam/tests/testGeneralSFMFactor.cpp
@@ -16,23 +16,24 @@
* @brief unit tests for GeneralSFMFactor
*/
-#include
-#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
#include
#include
using namespace boost;
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
+#include
+#include
using namespace std;
using namespace gtsam;
diff --git a/gtsam/slam/tests/testGeneralSFMFactor_Cal3Bundler.cpp b/gtsam/slam/tests/testGeneralSFMFactor_Cal3Bundler.cpp
index 76cf7d180..7698acae4 100644
--- a/gtsam/slam/tests/testGeneralSFMFactor_Cal3Bundler.cpp
+++ b/gtsam/slam/tests/testGeneralSFMFactor_Cal3Bundler.cpp
@@ -10,28 +10,30 @@
* -------------------------------------------------------------------------- */
/**
- * @file testGeneralSFMFactor.cpp
+ * @file testGeneralSFMFactor_Cal3Bundler.cpp
* @date Dec 27, 2010
* @author nikai
* @brief unit tests for GeneralSFMFactor
*/
-#include
-#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
#include
#include
-using namespace boost;
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
-#include
+#include
+#include
using namespace std;
using namespace gtsam;
@@ -146,8 +148,8 @@ vector genCameraVariableCalibration() {
return X ;
}
-shared_ptr getOrdering(const vector& X, const vector& L) {
- shared_ptr ordering(new Ordering);
+boost::shared_ptr getOrdering(const std::vector& X, const std::vector& L) {
+ boost::shared_ptr ordering(new Ordering);
for ( size_t i = 0 ; i < L.size() ; ++i ) ordering->push_back(Symbol('l', i)) ;
for ( size_t i = 0 ; i < X.size() ; ++i ) ordering->push_back(Symbol('x', i)) ;
return ordering ;
diff --git a/gtsam/slam/tests/testPlanarSLAM.cpp b/gtsam/slam/tests/testPlanarSLAM.cpp
index 8859f7a08..11efc7b5e 100644
--- a/gtsam/slam/tests/testPlanarSLAM.cpp
+++ b/gtsam/slam/tests/testPlanarSLAM.cpp
@@ -14,16 +14,16 @@
* @author Frank Dellaert
**/
+#include
+#include
+#include
+#include
+
#include
#include
-#include
-#include
-#include
-
using namespace std;
using namespace gtsam;
-using namespace planarSLAM;
// some shared test values
static Pose2 x1, x2(1, 1, 0), x3(1, 1, M_PI_4);
diff --git a/gtsam/slam/tests/testProjectionFactor.cpp b/gtsam/slam/tests/testProjectionFactor.cpp
index 80b35f269..2ec97f301 100644
--- a/gtsam/slam/tests/testProjectionFactor.cpp
+++ b/gtsam/slam/tests/testProjectionFactor.cpp
@@ -17,6 +17,7 @@
*/
#include
+#include
#include
using namespace std;
diff --git a/gtsam/slam/tests/testSerializationSLAM.cpp b/gtsam/slam/tests/testSerializationSLAM.cpp
index 4442d73fc..23093a28e 100644
--- a/gtsam/slam/tests/testSerializationSLAM.cpp
+++ b/gtsam/slam/tests/testSerializationSLAM.cpp
@@ -16,12 +16,12 @@
* @date Feb 7, 2012
*/
-#include
-#include
#include
#include
#include
-
+#include
+#include
+#include
#include
#include
diff --git a/gtsam/slam/tests/testSimulated2DOriented.cpp b/gtsam/slam/tests/testSimulated2DOriented.cpp
index b3d6e8d9e..afca72402 100644
--- a/gtsam/slam/tests/testSimulated2DOriented.cpp
+++ b/gtsam/slam/tests/testSimulated2DOriented.cpp
@@ -16,17 +16,17 @@
* @brief unit tests for simulated2DOriented
*/
-#include
-#include
-
-#include
-#include
#include
#include
+#include
+#include
+#include
using namespace std;
using namespace gtsam;
-using namespace simulated2DOriented;
+
+#include
+#include
// Convenience for named keys
Key kx(size_t i) { return Symbol('x',i); }
diff --git a/gtsam/slam/tests/testStereoFactor.cpp b/gtsam/slam/tests/testStereoFactor.cpp
index ffa512d96..9a8a27054 100644
--- a/gtsam/slam/tests/testStereoFactor.cpp
+++ b/gtsam/slam/tests/testStereoFactor.cpp
@@ -19,6 +19,7 @@
#include
#include
#include
+#include
#include
#include
diff --git a/gtsam/slam/tests/testVisualSLAM.cpp b/gtsam/slam/tests/testVisualSLAM.cpp
index 27b930022..dc9b64f4d 100644
--- a/gtsam/slam/tests/testVisualSLAM.cpp
+++ b/gtsam/slam/tests/testVisualSLAM.cpp
@@ -20,6 +20,7 @@
#include
#include
#include
+#include
#include
#include
diff --git a/gtsam/slam/visualSLAM.h b/gtsam/slam/visualSLAM.h
index 9933c4d9f..32824b60e 100644
--- a/gtsam/slam/visualSLAM.h
+++ b/gtsam/slam/visualSLAM.h
@@ -23,7 +23,6 @@
#include
#include
#include
-#include
#include
#include
#include
diff --git a/gtsam_unstable/slam/simulated3D.h b/gtsam_unstable/slam/simulated3D.h
index 66552b926..ef79991b8 100644
--- a/gtsam_unstable/slam/simulated3D.h
+++ b/gtsam_unstable/slam/simulated3D.h
@@ -23,7 +23,6 @@
#include
#include
#include
-#include
// \namespace
diff --git a/gtsam_unstable/slam/tests/testSimulated3D.cpp b/gtsam_unstable/slam/tests/testSimulated3D.cpp
index 5aca0ce3a..d7633f473 100644
--- a/gtsam_unstable/slam/tests/testSimulated3D.cpp
+++ b/gtsam_unstable/slam/tests/testSimulated3D.cpp
@@ -18,10 +18,11 @@
#include
#include
+#include
+#include
+#include
#include
#include
-#include
-#include
using namespace gtsam;
using namespace simulated3D;
diff --git a/tests/testBoundingConstraint.cpp b/tests/testBoundingConstraint.cpp
index 35b1833ee..d728742f7 100644
--- a/tests/testBoundingConstraint.cpp
+++ b/tests/testBoundingConstraint.cpp
@@ -15,12 +15,13 @@
* @author Alex Cunningham
*/
-#include
-
#include
+#include
#include
#include
+#include
+
namespace iq2D = simulated2D::inequality_constraints;
using namespace std;
using namespace gtsam;
diff --git a/tests/testDoglegOptimizer.cpp b/tests/testDoglegOptimizer.cpp
index ae8c6e00e..f175ca9f3 100644
--- a/tests/testDoglegOptimizer.cpp
+++ b/tests/testDoglegOptimizer.cpp
@@ -15,15 +15,17 @@
* @author Richard Roberts
*/
-#include
-#include
-#include
+#include
+#include
+#include
+#include
#include
#include
#include
-#include
-#include
-#include
+#include
+#include
+
+#include
#include
#include