12345qiupeng
/
gtsam
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use simpler normalization for max-product.

release/4.3a0
Kevin 2023-02-08 08:55:03 -05:00
parent 571b0f5e90
commit 9d0be8f2b2
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
gtsam/discrete/DiscreteFactorGraph.cpp
View File

@ -121,9 +121,10 @@ namespace gtsam {
for (auto&& factor : factors) product = (*factor) * product; for (auto&& factor : factors) product = (*factor) * product;
gttoc(product); gttoc(product);
// Normalize the product factor to prevent underflow // Sum all the potentials by pretending all keys are frontal:
Ordering ordering = Ordering::Colamd(DiscreteFactorGraph{product}); auto normalization = product.sum(product.size());
DecisionTreeFactor::shared_ptr normalization = product.sum(ordering);
// Normalize the product factor to prevent underflow.
product = product / (*normalization); product = product / (*normalization);
// max out frontals, this is the factor on the separator // max out frontals, this is the factor on the separator