From 498079777d200d34bde12d1471593174ddc1a107 Mon Sep 17 00:00:00 2001
From: Varun Agrawal <varagrawal@gmail.com>
Date: Tue, 8 Oct 2024 23:19:20 -0400
Subject: [PATCH] improved type aliasing

---
 gtsam/hybrid/HybridGaussianProductFactor.cpp | 2 +-
 gtsam/hybrid/HybridGaussianProductFactor.h   | 9 +++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/gtsam/hybrid/HybridGaussianProductFactor.cpp b/gtsam/hybrid/HybridGaussianProductFactor.cpp
index 375349f9b..e71201ceb 100644
--- a/gtsam/hybrid/HybridGaussianProductFactor.cpp
+++ b/gtsam/hybrid/HybridGaussianProductFactor.cpp
@@ -24,7 +24,7 @@
 
 namespace gtsam {
 
-using Y = HybridGaussianProductFactor::Y;
+using Y = GaussianFactorGraphValuePair;
 
 /* *******************************************************************************/
 static Y add(const Y& y1, const Y& y2) {
diff --git a/gtsam/hybrid/HybridGaussianProductFactor.h b/gtsam/hybrid/HybridGaussianProductFactor.h
index b4c51dbd3..508113e87 100644
--- a/gtsam/hybrid/HybridGaussianProductFactor.h
+++ b/gtsam/hybrid/HybridGaussianProductFactor.h
@@ -26,12 +26,13 @@ namespace gtsam {
 
 class HybridGaussianFactor;
 
+using GaussianFactorGraphValuePair = std::pair<GaussianFactorGraph, double>;
+
 /// Alias for DecisionTree of GaussianFactorGraphs and their scalar sums
 class GTSAM_EXPORT HybridGaussianProductFactor
-    : public DecisionTree<Key, std::pair<GaussianFactorGraph, double>> {
+    : public DecisionTree<Key, GaussianFactorGraphValuePair> {
  public:
-  using Y = std::pair<GaussianFactorGraph, double>;
-  using Base = DecisionTree<Key, Y>;
+  using Base = DecisionTree<Key, GaussianFactorGraphValuePair>;
 
   /// @name Constructors
   /// @{
@@ -46,7 +47,7 @@ class GTSAM_EXPORT HybridGaussianProductFactor
    */
   template <class FACTOR>
   HybridGaussianProductFactor(const std::shared_ptr<FACTOR>& factor)
-      : Base(Y{GaussianFactorGraph{factor}, 0.0}) {}
+      : Base(GaussianFactorGraphValuePair{GaussianFactorGraph{factor}, 0.0}) {}
 
   /**
    * @brief Construct from DecisionTree